Indexed triangle strip cut for TriangleLL #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiglreith
approved these changes
Sep 11, 2017
| @@ -421,7 +421,8 @@ impl core::Factory<R> for Factory { | |||
| pInputElementDescs: input_element_descs.as_ptr(), | |||
| NumElements: input_element_descs.len() as u32, | |||
| }, | |||
| IBStripCutValue: winapi::D3D12_INDEX_BUFFER_STRIP_CUT_VALUE_DISABLED, | |||
| //IBStripCutValue: winapi::D3D12_INDEX_BUFFER_STRIP_CUT_VALUE_DISABLED, | |||
| IBStripCutValue: winapi::D3D12_INDEX_BUFFER_STRIP_CUT_VALUE_0xFFFFFFFF, //note: this works with U16 too! | |||
There was a problem hiding this comment.
Looks a bit hackish, but if it works .. (for dx12ll acceptable at least)
|
bors r+ |
Build failed |
|
Oh great:
|
|
Travis also fails with unknown errors, let's try again .. bors r+ |
Build failed |
|
Travis passed in the 2nd run and appveyor only fails on nightly, probably some temporary regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was done for a GPUWeb test (positive!), but I don't think why we'd want this wasted ;)