Format packing semantics, dx12 handling #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiglreith
approved these changes
May 17, 2018
| dim: $dim, | ||
| packed: $total > 0x1000, |
There was a problem hiding this comment.
Quite a bit of magic going on here but looks ok for now :p
| @@ -40,6 +40,11 @@ pub struct FormatDesc { | |||
| pub bits: u16, | |||
| /// Dimensions (width, height) of the texel blocks. | |||
| pub dim: (u8, u8), | |||
| /// The format representation depends on the endianness of the platform. | |||
| /// | |||
| /// * On little-endian systems, the actual oreder of components is reverse of what | |||
|
Thanks for the review!
Can't wait to make that portability pr, so let's proceed and follow up later with nit fixes.
Bors r=msiglreith
… On May 17, 2018, at 09:02, msiglreith ***@***.***> wrote:
@msiglreith approved this pull request.
Looks good, small nit.
(Discussed in gitter)
In src/hal/src/format.rs:
> dim: $dim,
+ packed: $total > 0x1000,
Quite a bit of magic going on here but looks ok for now :p
In src/hal/src/format.rs:
> @@ -40,6 +40,11 @@ pub struct FormatDesc {
pub bits: u16,
/// Dimensions (width, height) of the texel blocks.
pub dim: (u8, u8),
+ /// The format representation depends on the endianness of the platform.
+ ///
+ /// * On little-endian systems, the actual oreder of components is reverse of what
nit: oreder/order
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bors bot
added a commit
that referenced
this pull request
May 17, 2018
2037: Format packing semantics, dx12 handling r=msiglreith a=kvark Fixes all of the image related copy/blit CTS tests (>11K passes!). There are 0 failures in this category now and ~5 crashes due to #1945. PR checklist: - [ ] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [ ] tested examples with the following backends: Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all of the image related copy/blit CTS tests (>11K passes!). There are 0 failures in this category now and ~5 crashes due to #1945.
PR checklist:
makesucceeds (on *nix)make reftestssucceeds