Fix WebGL always presenting latest bound FBO #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
commented
Jul 9, 2019
| _ => unimplemented!(), | ||
| }; | ||
|
|
||
| let channel = config.format.base_format().1; |
There was a problem hiding this comment.
This code wasn't actually being used...
hecrj
force-pushed
the
fix/webgl-present-latest-fbo
branch
from
67363b5
to
1788c8a
Compare
- Unified swapchain creation and presentation. - Removed unused code. - Remove unnecessary unsafe block.
hecrj
force-pushed
the
fix/webgl-present-latest-fbo
branch
from
1788c8a
to
1474d0b
Compare
msiglreith
approved these changes
Jul 9, 2019
|
bors r=msiglreith |
bors bot
added a commit
that referenced
this pull request
Jul 9, 2019
2895: Fix WebGL always presenting latest bound FBO r=msiglreith a=hecrj When working on #2892, I noticed that when using WebGL with the GL backend, the latest bound FBO was being blitted to the default framebuffer, instead of the correct swapchain FBO. The changes in this PR fix this issue while: - Unifying swapchain creation and presentation - Removing related unused code - Removing a related unnecessary unsafe block PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Héctor Ramón Jiménez <hector0193@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #2892, I noticed that when using WebGL with the GL backend, the latest bound FBO was being blitted to the default framebuffer, instead of the correct swapchain FBO.
The changes in this PR fix this issue while:
PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed code