Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6/GL] descriptor write fixes with version bump #3466

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 5, 2020

Makes us run the cube and mipmap examples somewhat...
cc @zicklag

@zicklag
Copy link
Contributor

zicklag commented Nov 5, 2020

Cube runs for me now:

image

Still get the artifacts, but at this point maybe don't take my machine as a reference. I'm not the admin on my system so I can't change this at the moment, but I have to run the demo in a container because my host is missing some package so that it complains that the egl function could not be loaded. Also I'm running a hybrid GPU setup, so programs run on the CPU with a Mesa driver by default, but can optionally be started with the full Nvidia GPU. But I don't know that I can get the Nvidia GPU to work inside of the container so I can only really test how it runs with the Mesa driver right now, assuming I'm understanding the situation properly.

Anyway, looks like the fixes helped!

@kvark
Copy link
Member Author

kvark commented Nov 5, 2020

@zicklag ok, good, so at least we can reproduce the issue again.
On my macOS, the behavior of presentation is very strange: image shows up for a few seconds, then the screen is black for another few seconds, then it shows up again. It's strangely stable, I'm just confused to see the change at the second-scale as opposed to frame-scale or something.

@zicklag
Copy link
Contributor

zicklag commented Nov 5, 2020

Ooh, mipmap does work too. Still with the jagged edges, but cool!

image

@kvark
Copy link
Member Author

kvark commented Nov 5, 2020

Do you want to review the PR btw? :)

@zicklag
Copy link
Contributor

zicklag commented Nov 5, 2020

Do you want to review the PR btw? :)

No, but thanks. :) I've got some other stuff I've got to focus on now, but it was great to be able to help with all of this. Hopefully with OpenGL all connected to WGPU now it will be a lot easier for others to get into contributing and testing the GL backend. Can't wait to see how it progresses!

@kvark
Copy link
Member Author

kvark commented Nov 5, 2020

Could you file a bug about the jagged edges, specifying your configuration clearly? I know we had that in a few places, but these discussions were so long it's now difficult to recap.

@zicklag
Copy link
Contributor

zicklag commented Nov 5, 2020

Would it be appropriate just to update the original post for this issue: #3353?

@kvark
Copy link
Member Author

kvark commented Nov 5, 2020

Actually, yes, let's just work with #3353
Just to double-check, you weren't able to reproduce the issue on the quad example? I wonder if the clearing color takes part in this. Could you try changing wgpu-rs example to clear to a simple color (like black)? Could you try changing the quad example to clear to the same color as the cube does?

Copy link
Contributor

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 6, 2020

@bors bors bot merged commit 74e702e into gfx-rs:hal-0.6 Nov 6, 2020
@kvark kvark deleted the 0.6-gl branch November 6, 2020 05:31
@kvark kvark mentioned this pull request Nov 9, 2020
bors bot added a commit that referenced this pull request Nov 9, 2020
3471: [GL] descriptor fixes r=kvark a=kvark

Sibling of #3466 for master

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot added a commit that referenced this pull request Nov 9, 2020
3471: [GL] descriptor fixes r=kvark a=kvark

Sibling of #3466 for master

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot added a commit that referenced this pull request Nov 9, 2020
3471: [GL] descriptor fixes r=kvark a=kvark

Sibling of #3466 for master

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot added a commit that referenced this pull request Nov 9, 2020
3471: [GL] descriptor fixes r=kvark a=kvark

Sibling of #3466 for master

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot added a commit that referenced this pull request Nov 9, 2020
3471: [GL] descriptor fixes r=kvark a=kvark

Sibling of #3466 for master

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants