Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vk] fix viewport/scissor count validation error #3500

Merged
merged 1 commit into from Dec 2, 2020
Merged

[vk] fix viewport/scissor count validation error #3500

merged 1 commit into from Dec 2, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Dec 2, 2020

Fixes this VU reported in gfx-rs/wgpu#1059 :

0.375320 ERROR(no module):
VALIDATION [VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216 (-376016417)] : Validation Error: [ VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216 ] Object 0: handle = 0x2d93dbcf100, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xe99671df | vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is disabled, but pCreateInfos[0].pViewportState->viewportCount (=0) is not 1. The Vulkan spec states: If the multiple viewports feature is not enabled, viewportCount must be 1 (https://vulkan.lunarg.com/doc/view/1.2.141.0/windows/1.2-extensions/vkspec.html#VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216)
object info: (type: DEVICE, hndl: 3132066951424)

PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested on wgpu-rs examples

@kvark
Copy link
Member Author

kvark commented Dec 2, 2020

bors r+

@kvark kvark mentioned this pull request Dec 2, 2020
Closed
@bors
Copy link
Contributor

bors bot commented Dec 2, 2020

Build succeeded:

@bors bors bot merged commit 294bac8 into gfx-rs:master Dec 2, 2020
@kvark kvark deleted the vk-viewports branch December 2, 2020 21:31
@kvark kvark mentioned this pull request Dec 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monocodus monocodus[bot] monocodus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kvark