Bugs from Testing Wgpu with Gfx Master #1059
Comments
cwfitzgerald
added
type: bug
?/allOn swapchain creation, the program might crash with exit code Minimal example here: https://github.com/Systemcluster/wgpu-bug-crash-on-resize Traces: https://github.com/Systemcluster/wgpu-bug-crash-on-resize/tree/master/trace It also produces validation errors as reported in gfx-rs/wgpu-rs/issues/507 ?/vkNext to the Example here: https://github.com/Systemcluster/wgpu-bug-validation-errors Trace: https://github.com/Systemcluster/wgpu-bug-validation-errors/tree/master/trace |
3500: [vk] fix viewport/scissor count validation error r=kvark a=kvark Fixes this VU reported in gfx-rs/wgpu#1059 : > [0.375320 ERROR]()(no module): VALIDATION [VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216 (-376016417)] : Validation Error: [ VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216 ] Object 0: handle = 0x2d93dbcf100, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xe99671df | vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is disabled, but pCreateInfos[0].pViewportState->viewportCount (=0) is not 1. The Vulkan spec states: If the multiple viewports feature is not enabled, viewportCount must be 1 (https://vulkan.lunarg.com/doc/view/1.2.141.0/windows/1.2-extensions/vkspec.html#VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216) object info: (type: DEVICE, hndl: 3132066951424) PR checklist: - [x] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested on wgpu-rs examples Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
|
The viewport/scissor warning is getting fixed in gfx-rs/gfx#3500 |
all/dx12The examples leak memory heavily under DX12, 10-20 MB/sec, depending on the framerate. Reproduced on both AMD and NVidia hardware, so it's not a vendor/driver issue. Windows Task Manager shows a similar memory growth in the GPU Shared Memory graph. |
|
The only relevant issue we have on DX12 is gfx-rs/gfx#2556, and it's about texture updates, and it's quite old (could not be the case any more). Please file an issue about the memory leak you are seeing, and put everything you know into it. |
3499: [dx12] Fix `set_command_buffer_name` r=kvark a=yzsolt `CommandBuffer.raw` is null when the command buffer is not recording, so we have to store the name and set it later in `CommandBuffer::begin`. Fixes water and texture-arrays `wgpu-rs` examples: gfx-rs/wgpu#1059 PR checklist: - [ ] `make` succeeds (on *nix) - not applicable - [x] `make reftests` succeeds - [x] tested examples with the following backends: water and texture-arrays from wgpu-rs with dx12 backend Co-authored-by: Zsolt Bölöny <bolony.zsolt@gmail.com>
3548: Fixes Regretions from 0.6 to Master r=kvark a=cwfitzgerald This PR plus the gpu-alloc fixes all the DX11 specific issues in gfx-rs/wgpu#1059. These are all refcount issues, one was a double free of images, the other was some resources not being freed on the swapchain. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
1101: Bump gfx-hal and gpu-alloc r=kvark a=cwfitzgerald **Connections** Absorbs zakarumych/gpu-alloc#31 and gfx-rs/gfx#3548 (comment) **Description** This fixes the last of the DX11 issues listed in #1059. **Testing** Various examples ran. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
|
All issues in the original post have been solved at the current point. @Systemcluster can you retest to see if things are still an issue with current master whenever you get a chance? |
|
@cwfitzgerald Sure! Both issues still apply with the current wgpu-rs master, though as I understand wgpu-rs is still using the wgpu-core revision from dec. 18, so I'd have to check again following an update. |
|
@cwfitzgerald With the most recent master, the crash after resizing seems to only occur with the DX12 backend. The validation errors on Vulkan still appear. However, this might not be related to the gfx update after all, and is already tracked in gfx-rs/wgpu-rs/issues/507. The validation errors in the second issue still appear as well. Is there any additional information I can supply there? |
|
You don't need to wait for https://github.com/gfx-rs/wgpu-rs/issues/507#issuecomment-674353159 to be fixed. Instead, just don't skip the frame: always have at least a dummy pass that clears it. |
|
With the original bugs cleared, for sake of ease of tracking and clarity, I'm going to close this issue. @Systemcluster could you refile the issues you are having as new issues,and we'll take it from there. |
Specifically I was referring to |
Description
Various validation and other issues collected from my initial testing of wgpu on gfx-hal master.
Repro steps
Run the examples.
all/vk
all/dx12 and dx11
Under dx12, despite having two discrete graphics cards, wgpu chooses to run on WARP.
water and texture-arrays/dx12
Panic
cube/dx11
Missing outline, possibly missing feature not being exposed/hooked up.
all/dx11
Clicking the close button on the window results in exit code
2173according to powershell.msaa-line/dx11
Open application, click right arrow once, program crashes with exit code
0xc000041dshadow/dx11
Is still blank, see #1058.
water/dx11
Water is also blank, likely something up with having multiple renderpasses.
The text was updated successfully, but these errors were encountered: