Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment module #40

Merged
7 commits merged into from
Jul 1, 2014
Merged

Environment module #40

7 commits merged into from
Jul 1, 2014

Conversation

kvark
Copy link
Member

@kvark kvark commented Jul 1, 2014

TODO:

  • Basic environment module
  • Shortcut construction
  • Environment handle safety
  • Uniform matching and binding
  • Uniform blocks binding
  • Raw buffers construction and update
  • Reduce uniform value size (current is 68 due to the fixed-size matrix)
  • Check uniform semantics on bind / shortcut construction
  • Pass the whole structure when updating a uniform block (optional for this PR)

Fixes #19

This PR introduces the program environment struct (envir::Storage) that is filled in by the user, and serves as a source of data for program parameters.

@brendanzab
Copy link
Contributor

Now compiling on travis!

@kvark
Copy link
Member Author

kvark commented Jul 1, 2014

I think this PR is ready to go. Remaining sub-tasks should be fine with their own PRs:

  • reducing uniform size - I'm getting issues with it, and it's minor
  • passing the whole structures - still being discussed

@brendanzab
Copy link
Contributor

Dude, you are crazy productive, sorry for having trouble keeping up! It's awesome though :)

@photex
Copy link
Contributor

photex commented Jul 1, 2014

I'm up for the merge. Anyone have any reservations?

@ghost
Copy link

ghost commented Jul 1, 2014

The change looks fine to me. I am actually now blocked pending this change, so it would be nice to have it merged soon. But it's a big change and more review is always good.

@brendanzab
Copy link
Contributor

👍

@ghost ghost merged commit eb0a769 into gfx-rs:master Jul 1, 2014
This was referenced Jul 1, 2014
@kvark kvark deleted the envir branch July 1, 2014 20:55
@kvark kvark added feature and removed feature labels Jul 3, 2014
kvark added a commit to kvark/gfx that referenced this pull request Jun 14, 2015
adamnemecek pushed a commit to adamnemecek/gfx that referenced this pull request Apr 1, 2021
42: Remove glfw submodule r=nobody a=grovesNL

Fixes gfx-rs#41

I temporarily added a glfw submodule as part of gfx-rs#40 but it looks like it was mistakenly added as part of gfx-rs#39

Co-authored-by: Joshua Groves <josh@joshgroves.com>
adamnemecek pushed a commit to adamnemecek/gfx that referenced this pull request Apr 1, 2021
49: GLFW integration r=grovesNL a=kvark

This is gfx-rs#40 that is rebased and fixed a bit.

Co-authored-by: Joshua Groves <josh@joshgroves.com>
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design the shader parameters logic
3 participants