Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose IndexSlice #45

Merged
merged 1 commit into from Jul 1, 2014
Merged

expose IndexSlice #45

merged 1 commit into from Jul 1, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2014

No description provided.

@ghost ghost added question and removed question labels Jul 1, 2014
photex added a commit that referenced this pull request Jul 1, 2014
@photex
Merge pull request #45 from csherratt/index_slice
aaca873 
expose IndexSlice
@photex photex merged commit aaca873 into gfx-rs:master Jul 1, 2014
@kvark
Copy link
Member

kvark commented Jul 1, 2014

Weird that it merged, since my local copy (that was a part of #40) has this:

pub use render::mesh::{VertexCount, ElementCount, VertexSlice, IndexSlice};

@ghost
Copy link
Author

ghost commented Jul 1, 2014

@kvark I had to manually merge your change.

@kvark
Copy link
Member

kvark commented Jul 1, 2014

@csherratt Ah, I see. That went it before my PR.

adamnemecek pushed a commit to adamnemecek/gfx that referenced this pull request Apr 1, 2021
@bors @kvark
Merge gfx-rs#45
5acbf75 
45: Remove non-winit from the example r=grovesNL a=kvark

This are the follow-up fixes to gfx-rs#38 as suggested by the review

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvark @photex @csherratt