Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl-in] no error for duplicated type definition #2076

Closed
Wumpf opened this issue Oct 5, 2022 · 1 comment · Fixed by #2075
Closed

[wgsl-in] no error for duplicated type definition #2076

Wumpf opened this issue Oct 5, 2022 · 1 comment · Fixed by #2075
Labels
area: front-end Input formats for conversion kind: bug Something isn't working lang: WGSL WebGPU shading language

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 5, 2022 •
edited
Loading

given a wgsl shader containing

struct Uniforms {
    thing:f32,
}
struct Uniforms {
    thing2:f32,
}

naga should issue an error
@Wumpf Wumpf mentioned this issue Oct 5, 2022
Open
4 tasks
@SparkyPotato SparkyPotato mentioned this issue Oct 21, 2022
Merged
@JCapucho JCapucho added kind: bug Something isn't working lang: WGSL WebGPU shading language area: front-end Input formats for conversion labels Oct 21, 2022
@teoxoy
Copy link
Member

teoxoy commented Nov 4, 2022

For reference, the redefinition detection implemented in #1551 doesn't cover types.

jimblandy added a commit to SparkyPotato/naga that referenced this issue Jan 12, 2023
@SparkyPotato @teoxoy @jimblandy
[wgsl-in] Implement module-level scoping.
1976586 
Fixes gfx-rs#1745: Support out-of-order module scope declarations in WGSL
Fixes gfx-rs#1044: Forbid local variable shadowing in WGSL
Fixes gfx-rs#2076: [wgsl-in] no error for duplicated type definition
Fixes gfx-rs#2071: Global item does not support 'const'
Fixes gfx-rs#2105: [wgsl-in] Type aliases for a vecN<T> doesn't work when constructing vec from a single argument
Fixes gfx-rs#1775: Referencing a function without a return type yields an unknown identifier error.
Fixes gfx-rs#2089: Error span reported on the declaration of a variable instead of its use
Fixes gfx-rs#1996: [wgsl-in] Confusing error: "expected unsigned/signed integer literal, found '1'"

Separate parsing from lowering by generating an AST, which desugars as
much as possible down to something like Naga IR. The AST is then used
to resolve identifiers while lowering to Naga IR.

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: front-end Input formats for conversion kind: bug Something isn't working lang: WGSL WebGPU shading language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wgsl-in] Implement module-level scoping SparkyPotato/naga
3 participants
@Wumpf @teoxoy @JCapucho