[wgsl-in] Don't allow redefinition of module scope identifiers #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Nov 25, 2021
There was a problem hiding this comment.
We need to forbid any kind of name collision at the module scope. Functions are one of many. Does it make sense to have this logic finding collisions for functions only, still? Perhaps, we need just a set of strings that are forbidden for names, which we grow as we scan the module.
Gordon-F
force-pushed
the
wgsl_shadow
branch
from
14a5e88
to
1fa51fb
Compare
Gordon-F
changed the title
kvark
reviewed
Nov 26, 2021
Gordon-F
force-pushed
the
wgsl_shadow
branch
from
1fa51fb
to
cfd0b78
Compare
|
Something wrong with CI. |
|
@kvark ready for merge. |
kvark
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess fix for #1480.