Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement const-expressions (phase 2) #2309

Merged
merged 37 commits into from
Oct 12, 2023
Merged

Implement const-expressions (phase 2) #2309

merged 37 commits into from
Oct 12, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Apr 21, 2023 •
edited
Loading

@teoxoy teoxoy force-pushed the const-expressions-2 branch 2 times, most recently from 8f3c447 to 059f6fb Compare May 10, 2023 14:41
@teoxoy teoxoy force-pushed the const-expressions branch 5 times, most recently from 3df6907 to 48557bb Compare May 11, 2023 18:11
@jimblandy jimblandy mentioned this pull request May 12, 2023
Open
@teoxoy teoxoy force-pushed the const-expressions-2 branch 3 times, most recently from 4f161cf to 502e585 Compare May 12, 2023 14:13
@teoxoy teoxoy force-pushed the const-expressions branch 2 times, most recently from aa77c97 to d19dca3 Compare June 2, 2023 14:14
@teoxoy teoxoy force-pushed the const-expressions-2 branch 3 times, most recently from 8af8818 to be9d9b2 Compare June 12, 2023 15:14
@teoxoy teoxoy changed the base branch from const-expressions to master July 31, 2023 13:53
@teoxoy teoxoy force-pushed the const-expressions-2 branch 2 times, most recently from a79b7ee to f06520f Compare July 31, 2023 15:01
@teoxoy teoxoy mentioned this pull request Jul 31, 2023
Merged
@teoxoy teoxoy mentioned this pull request Aug 11, 2023
Closed
@jimblandy
Copy link
Member

@teoxoy Could you rebase this on current trunk?

Also, it's not a draft any more, right?

@jimblandy
Copy link
Member

Rebased on current trunk.

@jimblandy jimblandy marked this pull request as ready for review September 11, 2023 19:52
teoxoy and others added 19 commits October 11, 2023 17:03
@teoxoy @jimblandy
avoid having constants pointing to other constants
4b4b0d3
@teoxoy @jimblandy
[wgsl-in] don't treat let declarations as const declarations
9d87d9e
@teoxoy @jimblandy
[wgsl] test @workgroup_size attribute with constants
f06eee9
@teoxoy @jimblandy
[wgsl] test const evaluation of division and multiplication
303a3cd
@teoxoy @jimblandy
[wgsl] test usage of constants in switch cases
82a3613
@teoxoy @jimblandy
[const-eval] add wgsl/glsl behavior switch to evaluator
b46ea49
@teoxoy @jimblandy
[const-eval] check number of arguments for math functions
d87231b
@teoxoy @jimblandy
[const-eval] account for ZeroValue index for AccessIndex expression
c24ab86
@teoxoy @jimblandy
[const-eval] implement pow & clamp built-in functions properly
f219e93
@teoxoy @jimblandy
[const-eval] allow bitcast, select and relational functions for GLSL …
da17650 
…since they should be supported
@teoxoy @jimblandy
[const-eval] evaluate BinaryOperator::Modulo correctly (use the tru…
18f4de7 
…ncated version instead of floored)
@teoxoy @jimblandy
[const-eval] error on invalid binary operations
b737d3e
@jimblandy
Properly recognize Literal expressions as non-dynamic indices. (#2537)
233c6c6 
Restore `negative_index` test in `tests/wgsl-errors.rs`, as part of
the `invalid_arrays` test function.
@teoxoy @jimblandy
Avoid FXC's error X3694: race condition writing to shared resource de…
c216a13 
…tected
@teoxoy @jimblandy
[const-eval] error on NaN and infinite floats
9171884
@teoxoy @jimblandy
avoid const-evaluating the operators.wgsl snapshot
260effb
@jimblandy
[wgsl-in] Document necessity of force_non_const.
ca46c6d
@jimblandy
Some documentation for ConstantEvaluator.
a0e0242
@teoxoy @jimblandy
[valid] check local variable initializer is const
61d91eb
@teoxoy teoxoy requested a review from a team as a code owner October 12, 2023 00:03
jimblandy
jimblandy approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go.

@teoxoy teoxoy merged commit 1b485ea into master Oct 12, 2023
14 checks passed
@teoxoy teoxoy deleted the const-expressions-2 branch October 12, 2023 11:13
@jimblandy jimblandy mentioned this pull request Oct 24, 2023
Closed
@chenrui333 chenrui333 mentioned this pull request Oct 25, 2023
Merged
@DJMcNab DJMcNab mentioned this pull request Oct 27, 2023
Merged
3 tasks
@teoxoy teoxoy mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@teoxoy @jimblandy