-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wgsl-in] Implement const expressions #1829
Comments
The link is broken af far as I can tell, btw. I dont know if there is a persistent link and whether it would be a good idea to use that one, but... As far as I understand: These are expressed as These new const declarations reintroduce syntax that was used in the past, but meant something slightly different back then I believe. I'm leaving this here to 1. validate my understanding and 2. to hopefully make this discoverable when searching issues. As it stands, if someone reads the official spec, and tries to use this software, they might be confused, as I was. |
I believe the link should refer to here: https://gpuweb.github.io/gpuweb/wgsl/#const-expressions "creation-time expression" was renamed to "const-expression" by gpuweb/gpuweb#3189 |
…s global scope FIXES BUG: tensorflow#6746 Deno uses Naga for wgsl compilation, but Naga currently uses let for global constants(will be fixed in gfx-rs/naga#1829). This PR helps WebGPU to run pose-detection models on Deno by removing global constants in shaders. Address comments
* [webgpu] Use numbers directly instead of `const variables` in shader's global scope FIXES BUG: #6746 Deno uses Naga for wgsl compilation, but Naga currently uses let for global constants(will be fixed in gfx-rs/naga#1829). This PR helps WebGPU to run pose-detection models on Deno by removing global constants in shaders.
…7193) * [webgpu] Use numbers directly instead of `const variables` in shader's global scope FIXES BUG: tensorflow#6746 Deno uses Naga for wgsl compilation, but Naga currently uses let for global constants(will be fixed in gfx-rs/naga#1829). This PR helps WebGPU to run pose-detection models on Deno by removing global constants in shaders.
https://gpuweb.github.io/gpuweb/wgsl/#const-expressions
Spec PR: gpuweb/gpuweb#2668
The text was updated successfully, but these errors were encountered: