Add Capabilities::ATOMIC_COMPARE_EXCHANGE_WEAK.
#2503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess adding a temporary capability for this is ok but since If we move forward with the capability, we need to set it in wgpu and also remember to remove it once we add support for |
Hmm. That's a fair question. |
We haven't finished implementing WGSL's `atomicCompareExchangeWeak` on all platforms (#1413). It's valuable to have some configuration of validation that guarantees backends will succeed, and adding a `Capabilities` bit that is included by default but can be turned off accomplishes that.
jimblandy
force-pushed
the
atomic-compare-exchange-weak-capability
branch
from
2b88d83
to
ce8df06
Compare
|
Yeah, I don't think this is a good idea after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't finished implementing WGSL's
atomicCompareExchangeWeakon all platforms: wgpu#4364. It's valuable to have some configuration of validation that guarantees backends will succeed, and adding aCapabilitiesbit that is included by default but can be turned off accomplishes that.