Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate on sdk-1.3.268 #244

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Regenerate on sdk-1.3.268 #244

merged 4 commits into from
Dec 1, 2023

Conversation

exrook
Copy link
Contributor

@exrook exrook commented Oct 25, 2023

Had to add another rename rule of use -> usage for CooperativeMatrixUse from SPV_KHR_cooperative_matrix to get this to compile.

@exrook
Copy link
Contributor Author

exrook commented Oct 25, 2023 •
edited
Loading

forgot to update the crate versions, rebase inbound

@exrook exrook mentioned this pull request Oct 25, 2023
Closed
@exrook exrook marked this pull request as draft October 25, 2023 13:22
@exrook exrook marked this pull request as ready for review October 25, 2023 13:53
@exrook exrook changed the title Regenerate on sdk-1.3.268 Regenerate on sdk-1.3.268 and bump spirv version to 0.3.0, rspirv to 0.12.0 Nov 6, 2023
@MarijnS95
Copy link
Collaborator

forgot to update the crate versions, rebase inbound

Can you drop this? It's very uncommon for a feature PR to proactively bump the version. Rather, this should happen in a separate commit (that maybe also updates versions, readmes and changelogs) by the maintainer.

@exrook
Copy link
Contributor Author

exrook commented Nov 17, 2023

forgot to update the crate versions, rebase inbound

Can you drop this? It's very uncommon for a feature PR to proactively bump the version. Rather, this should happen in a separate commit (that maybe also updates versions, readmes and changelogs) by the maintainer.

Got it, done!

@exrook exrook changed the title Regenerate on sdk-1.3.268 and bump spirv version to 0.3.0, rspirv to 0.12.0 Regenerate on sdk-1.3.268 Nov 17, 2023
MarijnS95
MarijnS95 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a cursory view this looks good 👍

EDIT: Checked all the new Ops and it doesn't look like we need to treat any specially.

autogen/src/binary.rs Outdated Show resolved Hide resolved
@exrook
Copy link
Contributor Author

exrook commented Nov 18, 2023

The clippy error is coming from within bitflags, see bitflags/bitflags#373. Looks like the fix is to upgrade to bitflags 2.x

@exrook
Copy link
Contributor Author

exrook commented Nov 18, 2023

I see #243 already updates bitflags, I'll drop the update from this series

@exrook exrook force-pushed the master branch 2 times, most recently from f150a6a to 5fdf92e Compare November 18, 2023 20:47
@MarijnS95
Copy link
Collaborator

@exrook can you look into resolving the CI failures here? Thanks!

@exrook
Copy link
Contributor Author

exrook commented Nov 27, 2023

@MarijnS95 should be good now

@msiglreith msiglreith merged commit c16591f into gfx-rs:master Dec 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 approved these changes

@msiglreith msiglreith msiglreith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exrook @MarijnS95 @msiglreith