Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address CI failures and pretty-print bit enum operands #247

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Address CI failures and pretty-print bit enum operands #247

merged 3 commits into from
Nov 21, 2023

Conversation

msiglreith
Copy link
Contributor

No description provided.

@msiglreith msiglreith mentioned this pull request Nov 18, 2023
Closed
@MarijnS95
Copy link
Collaborator

and pretty-print bit enum operands

Otherwise it debug-prints the same enum variant double, right?

@msiglreith
Copy link
Contributor Author

I would output FunctionControl(INLINE | CONST) for example in the test

@MarijnS95
Copy link
Collaborator

MarijnS95 commented Nov 18, 2023 •
edited
Loading

Hmm for Display having just the variant name, but for Debug it seems nice to also include the type name?

@msiglreith
autogen: implement Display for bitenum types
979308b 
Replace the pretty-print `Debug` variant with `Display`.
`dr::Operands` will use `Display` for bitenum types now to avoid duplicate typenames
@msiglreith
Copy link
Contributor Author

Switched back to the default Debug impl and use Display instead to hide the duplicate type names, needed to touch some parts of the autogenerator

MarijnS95
MarijnS95 reviewed Nov 19, 2023
View reviewed changes
rspirv/dr/constructs.rs Outdated Show resolved Hide resolved
@msiglreith msiglreith merged commit a3b41ed into gfx-rs:master Nov 21, 2023
9 checks passed
@msiglreith msiglreith deleted the ci-fix branch November 21, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msiglreith @MarijnS95