Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog Conflicts are Annoying #3683

Open
Tracked by #3685
cwfitzgerald opened this issue Apr 13, 2023 · 1 comment
Open
Tracked by #3685

Changelog Conflicts are Annoying #3683

cwfitzgerald opened this issue Apr 13, 2023 · 1 comment
Labels
area: infrastructure Testing, building, coordinating issues help required We need community help to make this happen. type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

Right now, the way we manage our changelog is that each individual PR adds its own entry to the changelog in the appropriate section. This is a good first step as it decentralizes our changelog authoring and makes publishing less annoying.

This does leave us with two problems though:

  • Conflicts on the changelog happen a lot. Both in standard PRs and backporting PRs, the changelog will almost always be in conflict.
  • The changelog format isn't terribly strict and can often get munged by conflicts. This requires a decent amount of cleanup on publish.

We should investigate possible solutions to this problem and see if they are worth the trouble. One particular solution would be for each PR to include a yaml-type changelog in a separate file, then have a tool combine all of them into a single changelog. This should get rid of most of the merge points, but would require an xtask-like tool to merge all of them into the final changelog.

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request help required We need community help to make this happen. area: infrastructure Testing, building, coordinating issues labels Apr 13, 2023
@mockersf
Copy link
Contributor

On Bevy, we are using custom tooling that can extract sections from the PR description and merge them in a single file. It's also using PR tags for organisation.

At work, we are using https://github.com/changesets/changesets. It creates individual changelog files for each PR, and merge them at release time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Testing, building, coordinating issues help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants