Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo failing to load git submodule #41

Closed
swiftcoder opened this issue Jan 21, 2019 · 1 comment
Closed

Cargo failing to load git submodule #41

swiftcoder opened this issue Jan 21, 2019 · 1 comment

Comments

@swiftcoder
Copy link
Contributor

It looks like cargo doesn't support recursively loading git submodules in dependencies.

It works fine when one checks out the entire crate locally and depends on that directly, but if I point my crate's dependency at this git repository, I get the following:

$ cargo build
    Updating git repository `https://github.com/gfx-rs/wgpu`
error: failed to load source for a dependency on `wgpu`

Caused by:
  Unable to update https://github.com/gfx-rs/wgpu

Caused by:
  failed to update submodule `examples/vendor/glfw`

Caused by:
  no URL configured for submodule 'examples/vendor/glfw'; class=Submodule (17)
bors bot added a commit that referenced this issue Jan 21, 2019
42: Remove glfw submodule r=nobody a=grovesNL

Fixes #41

I temporarily added a glfw submodule as part of #40 but it looks like it was mistakenly added as part of #39

Co-authored-by: Joshua Groves <josh@joshgroves.com>
@grovesNL
Copy link
Collaborator

Thanks for reporting the issue. The git submodule was temporary and it wasn't supposed to have been added to master. It should be resolved with #42 which removes it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants