-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multithreaded Compute Segfaults in CI on GL/Linux #4285
Comments
Running as:
I get the following interesting message:
This seems to be here:
Edit: |
Note that this issue affects many wgpu tests, not just the compute:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Anyway, that's probably entirely different from the original issue, since it's all Vulkan. Filed separate issue #5084. |
It's not impossible these are the same problem, vulkan is still fully initialized on the GL tests |
Join all threads before returning from the test case, to ensure that we don't return from `main` until all open `Device`s have been dropped. This avoids a race condition in glibc in which a thread calling `dlclose` can unmap a shared library's code even while the main thread is still running its finalization functions. (See gfx-rs#5084 for details.) Joining all threads before returning from the test ensures that the Vulkan loader has finished `dlclose`-ing the Vulkan validation layer shared library before `main` returns. Remove `skip` for this test on GL/llvmpipe. With this change, that has not been observed to crash. Without it, the test crashes within ten runs or so. Fixes gfx-rs#5084. Fixed gfx-rs#4285.
Join all threads before returning from the test case, to ensure that we don't return from `main` until all open `Device`s have been dropped. This avoids a race condition in glibc in which a thread calling `dlclose` can unmap a shared library's code even while the main thread is still running its finalization functions. (See gfx-rs#5084 for details.) Joining all threads before returning from the test ensures that the Vulkan loader has finished `dlclose`-ing the Vulkan validation layer shared library before `main` returns. Remove `skip` for this test on GL/llvmpipe. With this change, that has not been observed to crash. Without it, the test crashes within ten runs or so. Fixes gfx-rs#5084. Fixed gfx-rs#4285.
Randomly, but consistently within the run, multithreaded compute segfaults in CI. This doesn't happen when I run it locally against llvmpipe. This doesn't happen when running it in CI on windows against llvmpipe.
I suspect this might be an issue with EGL, but I have no idea how to reproduce it.
ci-log.txt
The text was updated successfully, but these errors were encountered: