Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track texture layers and mips independently #44

Closed
kvark opened this issue Jan 23, 2019 · 0 comments · Fixed by #226
Closed

Track texture layers and mips independently #44

kvark opened this issue Jan 23, 2019 · 0 comments · Fixed by #226
Assignees
@kvark
Labels
type: enhancement New feature or request

Comments

@kvark
Copy link
Member

kvark commented Jan 23, 2019

This would allow mipmap generation on GPU and similar algorithms.
@kvark kvark added the type: enhancement New feature or request label Jan 23, 2019
@kvark kvark pinned this issue Feb 27, 2019
@kvark kvark mentioned this issue Mar 20, 2019
Closed
@kvark kvark self-assigned this Jun 9, 2019
@kvark kvark mentioned this issue Jun 12, 2019
Merged
4 tasks
bors bot added a commit that referenced this issue Jun 16, 2019
@bors @kvark
Merge #226
a667d50 
226: Tracking Rewrite r=grovesNL a=kvark

Fixes #44

The idea is to support independent tracking of sub-resources. Today, this is needed for textures, which can have individual layers and mipmap levels in different states at a time. Tomorrow, this will be needed for buffer sub-ranges.

The intent to hack it in grew into a complete rewrite of the tracker... The new approach is cleaner in a few places (e.g. `TrackPermit` is gone), but the implementation is obviously more complex. I tried to separate the levels from each other (see `ResourceState` and `RangedStates`) to fight complexity, but it requires a whole lot of testing infrastructure to be solid.

Also regresses #216 a bit, cc @arashikou : tracker is a relatively complex structure. I somehow doubt it's useful to look at it in debug spew. We may need to implement `Debug` manually for it before re-adding `Debug` derives on passes and command buffers.

TODO:
  - [x] documentation of tracking types
  - [x] unit tests for tracking logic
  - [x] actual testing with existing apps, ensure no regressions
  - [x] write a mipmap generation example

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors bors bot closed this as completed in #226 Jun 16, 2019
@kvark kvark unpinned this issue Jun 17, 2019
cwfitzgerald pushed a commit that referenced this issue Oct 26, 2023
@daxpedda
Bump bitflags to v2 (#44)
777c5c1
RandyMcMillan pushed a commit to RandyMcMillan/wgpu that referenced this issue Jun 19, 2024
@hecrj
Merge pull request gfx-rs#44 from hecrj/improvement/update-wgpu
6790f4b 
Update `wgpu` to `0.4` in `iced_wgpu`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tracking Rewrite kvark/wgpu
1 participant
@kvark