Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevy_rapier shaders fail on AMD Radeon Pro Vega 20 #4526

Open
brandon-reinhart opened this issue Aug 1, 2022 · 4 comments
Open

bevy_rapier shaders fail on AMD Radeon Pro Vega 20 #4526

brandon-reinhart opened this issue Aug 1, 2022 · 4 comments
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working

Comments

@brandon-reinhart
Copy link

Post here to cross link the issue from bevy_rapier : dimforge/bevy_rapier#226

The error says to report it here. I don't know if the problem is in the shader or the compilation of the shader.

Device: AMD Radeon Pro Vega 20
Backend: Metal

If you add RapierDebugRenderPlugin::default() to this device and backend the shaders fail to compile. This may actually be a naga bug in translating the shaders.

2022-08-01T21:44:16.808275Z ERROR wgpu::backend::direct: Shader translation error for stage VERTEX | FRAGMENT | VERTEX_FRAGMENT: new_render_pipeline_state: "depthAttachmentPixelFormat is not valid and shader writes to depth"
2022-08-01T21:44:16.808313Z ERROR wgpu::backend::direct: Please report it to https://github.com/gfx-rs/naga
2022-08-01T21:44:16.808371Z ERROR wgpu::backend::direct: Handling wgpu errors as fatal by default
thread 'main' panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_render_pipeline
    Internal error in VERTEX | FRAGMENT | VERTEX_FRAGMENT shader: new_render_pipeline_state: "depthAttachmentPixelFormat is not valid and shader writes to depth"

', /Users/nick/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-0.13.1/src/backend/direct.rs:2391:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
zsh: segmentation fault
@evxn
Copy link

evxn commented Aug 2, 2022

Have the same situation on mac with no discreet card. So the issue seems to be unrelated to a specific video card and likely more broad.

@JCapucho JCapucho added kind: bug lang: Metal Metal Shading Language area: naga back-end Outputs of naga shader conversion labels Aug 6, 2022
@CleanCut
Copy link

AFAICT it is happening more broadly for macOS: dimforge/bevy_rapier#230

I'm using an M1 chip and have the same error (info in issue above).

@CleanCut
Copy link

This was fixed downstream in dimforge/bevy_rapier#238

@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added type: bug Something isn't working and removed kind: bug labels Oct 25, 2023
@teoxoy
Copy link
Member

teoxoy commented Nov 3, 2023

We are most likely missing this piece of validation.

image

@teoxoy teoxoy added area: validation Issues related to validation, diagnostics, and error handling and removed area: naga back-end Outputs of naga shader conversion naga Shader Translator lang: Metal Metal Shading Language labels Nov 3, 2023
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

6 participants