Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all bitflag names to plural #1576

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Switch all bitflag names to plural #1576

merged 2 commits into from
Jun 30, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented Jun 30, 2021

Connections
#1471 added a lot of singular bitflag names. Previously, we weren't really consistent.

Description
This PR changes all of the names to be plural, except for a few that don't imply singularity, and are matching WebGPU upstream. Maybe we need to convert them too?

Testing
self-tested

@kvark kvark requested a review from cwfitzgerald June 30, 2021 18:45
@kvark
Copy link
Member Author

kvark commented Jun 30, 2021

Got green light from Veloren and Bevy folks.
bors r=cwfitzgerald

@bors
Copy link
Contributor

bors bot commented Jun 30, 2021

@bors bors bot merged commit d8888cc into gfx-rs:master Jun 30, 2021
@kvark kvark deleted the bitflags branch June 30, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants