Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan: remove use of Vulkan12Features/Properties types #2936

Merged
merged 1 commit into from Sep 2, 2022

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Aug 3, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Fixes #2925

Description
This pull request stops using the PhysicalDeviceVulkan12 types. This means an implementation only uses types that are supported.

cc @Rigidity

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(We should wait until CI is cleared up before we merge this.)

@jimblandy
Copy link
Member

Rebased; added CHANGELOG.md entry

@jimblandy jimblandy enabled auto-merge (squash) September 2, 2022 20:48
@jimblandy jimblandy merged commit c519901 into gfx-rs:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation Errors With pNext Chain on Vulkan
2 participants