Correct create_surface_from_(offscreen)_canvas docs. #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
doc-web-canvas-creation-safety
branch
from
4d26f19
to
778be11
Compare
cwfitzgerald
approved these changes
Aug 28, 2022
The function's does not depend on the `canvas` argument meeting the given requirements to avoid undefined behavior, so it should just be a normal contract, not a safety contract.
jimblandy
force-pushed
the
doc-web-canvas-creation-safety
branch
from
778be11
to
00dcd60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function's does not depend on the
canvasargument meeting thegiven requirements to avoid undefined behavior, so it should just be a
normal contract, not a safety contract.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.