Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gl: ASTC_HDR feature detection #3042

Merged
merged 3 commits into from Oct 5, 2022
Merged

gl: ASTC_HDR feature detection #3042

merged 3 commits into from Oct 5, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Sep 21, 2022 •
edited

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
#2371

Testing
Tested locally on Android phone (OnePlus Ace Pro) via wgpu-on-app

cwfitzgerald
cwfitzgerald requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good outside one comment

wgpu-hal/src/gles/conv.rs Show resolved Hide resolved
cwfitzgerald
cwfitzgerald approved these changes Oct 5, 2022
View reviewed changes
wgpu-hal/src/gles/conv.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit 4992de5 into gfx-rs:master Oct 5, 2022
@jinleili jinleili deleted the gl-astc-hdr branch October 6, 2022 00:50
@teoxoy teoxoy mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jinleili @cwfitzgerald