Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement queue.copy_external_image_to_texture for WebGL2 and improve WebGPU Impl #3288

Merged
merged 21 commits into from Jan 24, 2023

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Dec 11, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Still todo:

Connections

Closes #1888.

Follows up on #2781.

Description

Implements copy_external_image_to_texture fully on both WebGPU and WebGL - including all 4 different types that are supported by WebGPU.

Testing

Testing todo.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #3288 (3886b8b) into master (c1a0912) will decrease coverage by 0.07%.
The diff coverage is 17.56%.

@@            Coverage Diff             @@
##           master    #3288      +/-   ##
==========================================
- Coverage   64.50%   64.42%   -0.08%     
==========================================
  Files          86       86              
  Lines       42691    42776      +85     
==========================================
+ Hits        27536    27558      +22     
- Misses      15155    15218      +63     
Impacted Files Coverage Δ
wgpu-core/src/conv.rs 92.42% <0.00%> (-4.41%) ⬇️
wgpu-core/src/device/queue.rs 70.33% <ø> (+0.14%) ⬆️
wgpu-hal/src/dx11/adapter.rs 0.00% <0.00%> (ø)
wgpu-hal/src/empty.rs 0.00% <ø> (ø)
wgpu-hal/src/gles/command.rs 72.13% <ø> (ø)
wgpu-hal/src/gles/mod.rs 61.53% <ø> (ø)
wgpu-hal/src/gles/queue.rs 61.31% <ø> (ø)
wgpu-hal/src/lib.rs 26.92% <ø> (ø)
wgpu-types/src/lib.rs 86.01% <0.00%> (-2.06%) ⬇️
wgpu/src/backend/direct.rs 56.59% <0.00%> (-0.28%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwfitzgerald cwfitzgerald force-pushed the copyExternalImageToTexture branch 2 times, most recently from 164a4a7 to fcd3d4f Compare January 5, 2023 23:57
@cwfitzgerald cwfitzgerald force-pushed the copyExternalImageToTexture branch 3 times, most recently from 6cc084b to c236020 Compare January 11, 2023 22:08
Cargo.toml Show resolved Hide resolved
@cwfitzgerald cwfitzgerald marked this pull request as ready for review January 18, 2023 20:59
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few comments, otherwise it looks good!

wgpu-types/src/lib.rs Show resolved Hide resolved
wgpu/tests/external_texture.rs Show resolved Hide resolved
wgpu/src/backend/web.rs Outdated Show resolved Hide resolved
wgpu/src/backend/web.rs Show resolved Hide resolved
wgpu/src/backend/web.rs Outdated Show resolved Hide resolved
wgpu-hal/src/lib.rs Outdated Show resolved Hide resolved
wgpu-hal/src/gles/command.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Show resolved Hide resolved
wgpu-core/src/device/queue.rs Outdated Show resolved Hide resolved
cwfitzgerald and others added 2 commits January 23, 2023 18:14
Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) January 24, 2023 18:32
@cwfitzgerald cwfitzgerald merged commit 95a760b into gfx-rs:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for GPUImageCopyExternalImage
4 participants