Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: correct bounds policy checking on MSL #3603

Merged
merged 3 commits into from Mar 21, 2023
Merged

feat: correct bounds policy checking on MSL #3603

merged 3 commits into from Mar 21, 2023

Conversation

FL33TW00D
Copy link
Contributor

@FL33TW00D FL33TW00D commented Mar 17, 2023 •
edited by teoxoy

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Fixes #3483

Description
Previously on metal, using create_shader_module_unchecked would not set the bounds check policy to unchecked.

Testing
Check the produced metal shader.

@FL33TW00D FL33TW00D changed the title feat: unchecked msl feat: correct bounds policy checking on MSL Mar 17, 2023
teoxoy
teoxoy requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; it looks good besides the comment!

wgpu-hal/src/metal/device.rs Outdated Show resolved Hide resolved
FL33TW00D
FL33TW00D commented Mar 21, 2023
View reviewed changes
Copy link
Contributor Author

@FL33TW00D FL33TW00D left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all good!

teoxoy
teoxoy approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoxoy teoxoy merged commit a502282 into gfx-rs:master Mar 21, 2023
@FL33TW00D FL33TW00D mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shader module unchecked doesn't disable bounds checking codegen
2 participants
@FL33TW00D @teoxoy