Use VK_EXT_robustness2 only when not using an outdated intel iGPU driver

[TheoDulka]

Checklist

• Run cargo clippy.
• Run cargo clippy --target wasm32-unknown-unknown if applicable.
• Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Fixes #4599, fixes bevyengine/bevy#8037 and fixes bevyengine/bevy#8395

Description
Intel iGPUs with outdated drivers can break rendering if VK_EXT_robustness2 is pushed.
The solution is to not push if its driver version is before 31.0.101.2115, because this one works. There's probably an earlier functional version as it was just the earliest version I could find and try (due to Intel's End Of Life on 6th gen proc).

Testing
Not really something testable beyond getting an Intel iGPU laptop and seeing if it is unable to render. I used the shadow example for my testing.

[cwfitzgerald]

Unfortunately I don't think this will work directly. You can't just remove the extension from the list.

We should instead just set the feature flag to false - in adapter.rs:236, we can just flip it false on this condition.

[TheoDulka]

Unfortunately I don't think this will work directly. You can't just remove the extension from the list.

Yeah I realize that now, but I don't understand how I would do this:

We should instead just set the feature flag to false - in adapter.rs:236, we can just flip it false on this condition.

[cwfitzgerald]

Test code looks good, just some changes on the enabling code.

Please re-request a review from me once the changes are addressed to make sure I see it!

[cwfitzgerald]

Nothing wrong with the code, just want teo to have a final look before we merge

[teoxoy]

Good stuff, thanks!

dismiss