Improve Instance::available_backend_features() on macOS. #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for macOS and Angle should add `Backends::GL` not `Backends::VULKAN`. Similarly, the comment gets updated to not refer to Vulkan. This code was introduced in gfx-rs#5167.
|
Should this be true for iOS as well and not just macOS? |
cwfitzgerald
approved these changes
Feb 5, 2024
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for macOS and Angle should add
Backends::GLnotBackends::VULKAN. Similarly, the comment gets updated to not refer to Vulkan.This code was introduced in #5167.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.The change that this is fixing is already covered in the changeling and hasn't been released yet.