Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement override-expression evaluation in functions #5387

Merged
merged 12 commits into from Mar 28, 2024
Merged

Implement override-expression evaluation in functions #5387

merged 12 commits into from Mar 28, 2024

Commits on Mar 14, 2024

  1. refactor try_eval_and_append body

    @teoxoy
    teoxoy committed Mar 14, 2024
    Copy the full SHA
    f6f6dba View commit details
    Browse the repository at this point in the history

  2. evaluate override-expressions in functions

    @teoxoy
    teoxoy committed Mar 14, 2024
    Copy the full SHA
    fc497c4 View commit details
    Browse the repository at this point in the history

  3. allow private variables to have an override-expression initializer

    @teoxoy
    teoxoy committed Mar 14, 2024
    Copy the full SHA
    4d73a81 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. [naga] Doc tweaks for back::pipeline_constants.

    @jimblandy
    jimblandy committed Mar 25, 2024
    Copy the full SHA
    68ce24f View commit details
    Browse the repository at this point in the history

  2. [naga] Simplify uses of replace in back::pipeline_constants.

    @jimblandy
    jimblandy committed Mar 25, 2024
    Copy the full SHA
    8f58266 View commit details
    Browse the repository at this point in the history

  3. [naga] Hoist ConstantEvaluator construction in process_function. 

    There's no need to build a fresh `ConstantEvaluator` for every
expression; just build it once and reuse it.
    @jimblandy
    jimblandy committed Mar 25, 2024
    Copy the full SHA
    bd9ae61 View commit details
    Browse the repository at this point in the history

  4. [naga] Let filter_emits_with_block operate on a &mut Block. 

    This removes some clones and collects, simplifies call sites, and
isn't any more complicated to implement.
    @jimblandy
    jimblandy committed Mar 25, 2024
    Copy the full SHA
    b5cec4f View commit details
    Browse the repository at this point in the history

  5. [naga] Tweak comments in ConstantEvaluator::try_eval_and_append. 

    I found I needed a little bit more detail here.
    @jimblandy
    jimblandy committed Mar 25, 2024
    Copy the full SHA
    7f8a56a View commit details
    Browse the repository at this point in the history

  6. [naga] Add missing newline to test input file.

    @jimblandy
    jimblandy committed Mar 25, 2024
    Copy the full SHA
    96be56f View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. [naga] Handle comparison operands in pipeline constant evaluation. 

    Properly adjust `AtomicFunction::Exchange::compare` after pipeline
constant evaluation.
    @jimblandy
    jimblandy committed Mar 26, 2024
    Copy the full SHA
    ab08e05 View commit details
    Browse the repository at this point in the history

  2. [naga] Spell out members in adjust_expr.

    @jimblandy
    jimblandy committed Mar 26, 2024
    Copy the full SHA
    86b056d View commit details
    Browse the repository at this point in the history

  3. [naga] Adjust RayQuery statements in override processing.

    @jimblandy
    jimblandy committed Mar 26, 2024
    Copy the full SHA
    28dc70e View commit details
    Browse the repository at this point in the history