Fix indexed drawing with RenderBundle #5441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Turns out index drawing with render bundles was completely broken due to a simple mistake in render bundle's index checking. The fix is a simple comparision flip, but the fact this wasn't tested is rather concerning! I expanded the
vertex_indices
test to account for this. The test is already fairly overloaded, but after originally starting a separate testsuite I figured this is after all a great spot for it, also all of the tests there should run anyways with render bundles as well.In the future we should add more tests that take subsets of vertex & index buffer and test various error cases as well.
Testing
Most of this PR is the test!
(and indeed it breaks without the fix)
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.