Clean up weak references to texture views and bind groups #5595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaopengli89
changed the title
|
Tagging jimb on this as he's most aware of the lifetime management in wgpu-core |
xiaopengli89
force-pushed
the
cleanup-weak-ref-to-texture-view
branch
2 times, most recently
from
1c964e5
to
977fb27
Compare
cwfitzgerald
added
the
PR: needs back-porting
jimblandy
requested changes
May 1, 2024
|
@xiaopengli89 I've pushed a commit that makes the change I suggested. Could you look it over and see if it seems okay, and verify that it does fix the leak? |
@jimblandy LGTM. |
xiaopengli89
force-pushed
the
cleanup-weak-ref-to-texture-view
branch
from
c7166d7
to
500804e
Compare
jimblandy
approved these changes
May 6, 2024
|
@jimblandy Sorry, we cannot use the change because |
Wumpf
pushed a commit
to Wumpf/wgpu
that referenced
this pull request
May 18, 2024
* Clean up weak references to texture views * add change to CHANGELOG.md * drop texture view before clean up * cleanup weak ref to bind groups * update changelog * Trim weak backlinks in their holders' triage functions. --------- Co-authored-by: Jim Blandy <jimb@red-bean.com>
ErichDonGubler
pushed a commit
that referenced
this pull request
May 18, 2024
* Clean up weak references to texture views * add change to CHANGELOG.md * drop texture view before clean up * cleanup weak ref to bind groups * update changelog * Trim weak backlinks in their holders' triage functions. --------- Co-authored-by: Jim Blandy <jimb@red-bean.com>
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this pull request
May 23, 2024
* Clean up weak references to texture views * add change to CHANGELOG.md * drop texture view before clean up * cleanup weak ref to bind groups * update changelog * Trim weak backlinks in their holders' triage functions. --------- Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup weak references to texture views and bind groups to prevent leak.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.