Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue SetDrawColorBuffers before clearing buffers in GLES, use clear_buffer_f32_slice instead of clear #5666

Merged
merged 4 commits into from
May 14, 2024
Merged

Issue SetDrawColorBuffers before clearing buffers in GLES, use clear_buffer_f32_slice instead of clear #5666

merged 4 commits into from
May 14, 2024

Commits on May 5, 2024

  1. Issue SetDrawColorBuffers commands before issuing ClearColor 

    This is necessary for glClearBuffer calls to work correctly on some machines (e.g. AMD Renoir graphics running on Linux). Without this, glClearBuffer calls are ignored.
    @nickguletskii
    nickguletskii committed May 5, 2024
    Configuration menu
    Copy the full SHA
    548fe57 View commit details
    Browse the repository at this point in the history

  2. Use clear_buffer_f32_slice instead of gl.clear to suppress WebGL warn… 

    …ings

This fixes the following WebGL warning: "WebGL warning: drawBuffers: `buffers[i]` must be NONE or COLOR_ATTACHMENTi."

When using native OpenGL, it is acceptable to call glDrawBuffers with an array of buffers where i != COLOR_ATTACHMENTi. In WebGL, this is not allowed.
    @nickguletskii
    nickguletskii committed May 5, 2024
    Configuration menu
    Copy the full SHA
    2b7b6d6 View commit details
    Browse the repository at this point in the history

  3. Run cargo fmt

    @nickguletskii
    nickguletskii committed May 5, 2024
    Configuration menu
    Copy the full SHA
    75e3656 View commit details
    Browse the repository at this point in the history

  4. Add changes for PR gfx-rsGH-5666 to the CHANGELOG

    @nickguletskii
    nickguletskii committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0dc4232 View commit details
    Browse the repository at this point in the history