Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DeviceLostReason serializable and deserializable. #5732

Merged
merged 1 commit into from
May 26, 2024
Merged

Make DeviceLostReason serializable and deserializable. #5732

merged 1 commit into from
May 26, 2024

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented May 23, 2024 •
edited

I'm not sure how is decided which types should be (de)serializable, but we want this in servo.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@sagudev sagudev requested a review from a team as a code owner May 23, 2024 05:13
Wumpf
Wumpf approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm not sure how is decided which types should be (de)serializable,

It's mostly driven by the trace/replay feature and user requests.

@Wumpf Wumpf merged commit dfd912e into gfx-rs:trunk May 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sagudev @Wumpf