Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naga: Remove feature std for indexmap #6019

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Jul 23, 2024

Description
This was added in gfx-rs/naga#2062

This was needed before version 2, but not in version 2, so it should be safe to remove now as it is enabled by default.

Testing
Compilation.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file. EDIT from @ErichDonGubler: Not necessary. 🙂

@waywardmonkeys waywardmonkeys requested a review from a team as a code owner July 23, 2024 06:30
@waywardmonkeys waywardmonkeys force-pushed the remove-feature-std-for-indexmap branch from 1750a50 to 473db0e Compare July 23, 2024 06:45
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was added in gfx-rs/naga#2062

This was needed before version 2, but not in version 2, so it
should be safe to remove now as it is enabled by default.
@ErichDonGubler ErichDonGubler force-pushed the remove-feature-std-for-indexmap branch from 473db0e to 79ff0ac Compare July 24, 2024 13:55
@ErichDonGubler
Copy link
Member

Just waiting on @gfx-rs/naga here; wish I could just push it.

@teoxoy teoxoy merged commit ea81a24 into gfx-rs:trunk Jul 24, 2024
25 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-feature-std-for-indexmap branch July 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants