Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct report generation to use custom template #364

Conversation

tynsci
Copy link
Collaborator

@tynsci tynsci commented May 23, 2023

  • ensures skeleton.Rdm is correctly updated so changes are reflected in output

@tynsci tynsci requested a review from mattfidler May 23, 2023 08:12
@mattfidler
Copy link
Collaborator

These dont pass CI.

@mattfidler
Copy link
Collaborator

Can you make sure the CI works before I review, please.

@codecov-commenter
Copy link

Codecov Report

Merging #364 (3a06bc3) into master (950357c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   86.70%   86.71%           
=======================================
  Files          45       45           
  Lines        4243     4246    +3     
=======================================
+ Hits         3679     3682    +3     
  Misses        564      564           
Impacted Files Coverage Δ
R/pmx-report.R 84.31% <100.00%> (+0.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattfidler
Copy link
Collaborator

@tynsci any progress here. The due date is coming soon before we are kicked off of CRAN

@mattfidler mattfidler merged commit a9ba7d1 into ggPMXdevelopment:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants