Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated tests #68

Merged
merged 14 commits into from
Mar 11, 2022
Merged

Add automated tests #68

merged 14 commits into from
Mar 11, 2022

Conversation

rafaelmds
Copy link
Contributor

@rafaelmds rafaelmds commented Mar 8, 2022 •
edited
Loading

Use docker env to run a simplified version of examples.

Initially, tests execution is set to only run manually.
We need to find a strategy to limit tests action to save time quota of GH actions.

Note: Make sure to export env variables PETSC_DIR (and `PETSC_ARCH', if not using prefix installation).

  • Update docs.

Addresses #53.

@rafaelmds rafaelmds requested a review from aguspesce March 8, 2022 02:53
@rafaelmds
Copy link
Contributor Author

rafaelmds commented Mar 8, 2022 •
edited
Loading

For reference: In @victorsacek machine, MPIEXEC was not set being set by the scripts. An error pop up not recognizing -n option.

@rafaelmds
Copy link
Contributor Author

I did some refactor.

Now, make test is working on my machine. Just need to export env variables: PETSC_DIR (and `PETSC_ARCH', if not using prefix installation).

@rafaelmds rafaelmds changed the title WIP - Add automated tests Add automated tests Mar 10, 2022
@rafaelmds rafaelmds changed the title Add automated tests WIP - Add automated tests Mar 10, 2022
@rafaelmds rafaelmds changed the title WIP - Add automated tests Add automated tests Mar 11, 2022
@victorsacek victorsacek merged commit 145424b into main Mar 11, 2022
@victorsacek victorsacek deleted the add-automated-tests branch March 11, 2022 16:52
@rafaelmds rafaelmds mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguspesce aguspesce Awaiting requested review from aguspesce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelmds @victorsacek