Adds Swift Package declaration for GGML #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows importing ggml as package dependency in llama.cpp and whisper.cpp - resolves issues with duplicate symbol error when importing llama.cpp and whisper.cpp as package dependency
This was referenced Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding both whisper.cpp and llama.cpp as package dependency in Xcode - we run into "duplicate declarations of symbols" issue as both of these package uses the same source files for ggml.
Adding this swift package to ggml and importing it as a dependency to both whisper.cpp and llama.cpp solves the issue.
Once this pull request is merged, merge the pull requests to both whisper.cpp and llama.cpp that use ggml as dependency.