Updates Package.swift to use ggml as package dependency #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
added a commit
that referenced
this pull request
Feb 12, 2024
jiahansu
pushed a commit
to OOPRY/whisper.cpp
that referenced
this pull request
Apr 17, 2024
* Revert "swift : update Package.swift to use ggml as package dependency (ggerganov#1701)" This reverts commit 993acb5. * spm : add ggml.h
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
…anov#1701) * updates Package.swift to use ggml as dependency * cleans up the Package.swift file by removing redundant source files * updates ggml url src to ggerganov
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
* Revert "swift : update Package.swift to use ggml as package dependency (ggerganov#1701)" This reverts commit 993acb5. * spm : add ggml.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding both whisper.cpp and llama.cpp as package dependency in Xcode - we run into "duplicate declarations of symbols" issue as both of these package uses the same source files for ggml.
Adding a swift package declaration to ggml (ggerganov/ggml/pull/674) and importing it as a dependency to both whisper.cpp and llama.cpp solves the issue.
Once the pull request (ggerganov/ggml/pull/674) is merged, merge this pull requests to whisper.cpp that use ggml as dependency.
Related: (llama.cpp/pull/4691)