Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overriding namespace when calling Scan and Resolve #5

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

ggicci
Copy link
Owner

@ggicci ggicci commented Oct 2, 2023

also...

  1. removed the ReplaceDirectiveExecutor API
  2. removed some error constants

also...

1. removed the ReplaceDirectiveExecutor API
2. removed some error constants
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ff1212b) 100.00% compared to head (f6b3757) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          381       382    +1     
=========================================
+ Hits           381       382    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
errors.go 100.00% <100.00%> (ø)
namespace.go 100.00% <100.00%> (ø)
resolver.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ggicci ggicci merged commit 1635467 into main Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants