-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use aes() and pass (or wrap) custom functions #90
Conversation
@briatte, can you take a look at this branch and mess around with ggpairs? I'd like to see if it's more fluid / non confusing. I still have to reduce the parameters in the main |
@schloerke I'm looking at the function's examples right now, after adapting them to a different dataset (the Here are two first impressions:
I believe that you really need a vignette for In fact, as far as I understand, pretty much every major function of
Adding a theme to library(questionr)
data(hdv2003)
p = ggpairs(
hdv2003[, 2:4 ],
upper = list(continuous = "density", combo = "box"),
lower = list(continuous = "points", combo = "dot")
)
p + theme_bw() How about allowing this: ggpairs(
hdv2003[, 2:4 ],
upper = list(continuous = "density", combo = "box"),
lower = list(continuous = "points", combo = "dot"),
theme = theme_bw()
) What do you think? |
* params: (46 commits) typo fixed stringr imports issue fixed tests for ggpairs add 'Diag' to all diagonal plot fns. must require Diag for diagonal plots documented added rescale arg to barDiag and densityDiag fixed typo document better name recognition for functions supplied within ggpairs fix examples in ggpairs document mapping in ggpairs clearer error message when supplying a nonexistent function updated ggally_cor to use non-ugly args better naming for wraps remove params args in tests of ggpairs fix tests to use updated mapping arg and wrap all binwidth fns make whole error output into one output if a wrapped function is wrapped again, reduce to one wrap more ways to check if a plot is blank documented ...
can not change these
* params: documented documented updated Roxygen version to 4.1.1
* params: added a code file for covr to run code coverage added Rplots to ignores added notes on sudo for travis require sudo :-/ travis sudo false. trying to upgrade to new travis infra added travis to be built. removed sudo from travis
be able to pass functions directly to
ggpairs
Ex: