Support for special file names, CMake, Makefiles and Rakefiles #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for this patch! I've been wanting |
|
Hi. Looks like there was a release recently and this PR was not either merged or explicitly rejected. Is there any way I could help this getting merged? |
|
Yeah, this project has quite a few stale/ignored PRs, but such is life in the open source world. If it makes you feel any better, I merged this into my personal fork. 😃 I hope it goes upstream still because resolving filetype merge conflicts will be a bitch until then. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds special filenames to go with extensions, to add support for CMakeLists.txt, Makefile, Rakefile and possible other special files.
A second commit reduces copying and fixes potential buffer overrun if a single filename/extension takes over SINGLE_EXT_LEN or more or a single language has more than MAX_EXTENSIONS extensions, which would overwrite the zero byte or null pointer at end of array.