Incorrect type returned from falsey 0.0 #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for the package :) it's really useful.
I think your
test_nullable_types_gen
test fails if run with sufficient random data:For example, here I have changed the number of generated values from 100 to 100,000 to produce an error.
In this case in particular, it is because occasionally the float
0.0
is generated, which is falsey and so gets passed through as a float. Making the check explicitly foris not None
fixes this.Unfortunately, I can't come up with a better way to permanently fix the test...
If you can suggest anything, I am happy to add.
Thanks!
Akhil