New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and simplify the treatment of implicit binding #532
Draft
Ericson2314
wants to merge
59
commits into
ghc-proposals:master
Choose a base branch
from
Ericson2314:type-variables
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 11 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
0a1269a
Clean up and simplify the treatment of implicit binding
Ericson2314 781a39a
principles: Fix reST
Ericson2314 5d4bd60
532: Copy template
Ericson2314 f07d9eb
532: Add meta-proposal
Ericson2314 0334f22
523 Fix typo
Ericson2314 b20db07
448: Improve flow for pattern signatures and binding motivation
Ericson2314 e198d72
523: Fix typo
Ericson2314 fd8c09d
Apply suggestions fixing typos from code review
Ericson2314 2fee77a
Fix typo in principles.rst
Ericson2314 4fd1cc3
Update proposals/0448-type-variable-scoping.rst
Ericson2314 fd9a254
532: Replace "arity" with something more clear
Ericson2314 b936b80
Fix typos
Ericson2314 295f297
532: Fix typo
Ericson2314 3acf93f
Fix formatting
nomeata 9ab6da7
Actually we did get rid of `-XPatternSignatureBinds`
Ericson2314 93021f4
532: Connect principles to practical changes
Ericson2314 2ba8d2d
Merge branch 'type-variables-reformat' into type-variables-2
Ericson2314 639e0d5
Add missing link
Ericson2314 898151f
Merge remote-tracking branch 'upstream/master' into type-variables
Ericson2314 32fd7b6
532: Fix typos
Ericson2314 b43c752
principles: Shrink diff in one place
Ericson2314 b347f85
425, principles: Revert link from 425 to the principles
Ericson2314 df63606
Apply suggestions from code review
Ericson2314 2bd421f
532: Make sure other proposals are linked
Ericson2314 57da8dc
448: Fix reflow to match master
Ericson2314 8811e59
Add examples to rest of `-XImplicitBinds` in proposal
Ericson2314 cf52f07
532: Demonstrate the #270 interaction with example
Ericson2314 084d901
448: Demonstrate the ``-XKindSignatures`` ret-con
Ericson2314 f2568b0
448: Expand on iteraction between `-XNoImplicitBinds` and `-Wpuns`
Ericson2314 3079de1
448: Fix typo
Ericson2314 002d686
532: Fix links
Ericson2314 4fe6730
Merge remote-tracking branch 'upstream/master' into type-variables
Ericson2314 462cdc5
532: No more changes to 425
Ericson2314 8584f5f
448: Remove a trailing space
Ericson2314 7c0a98d
523: Add an explicit summary list of changes
Ericson2314 4556c0e
448: Fix stray line breaks
Ericson2314 a34fa49
Merge remote-tracking branch 'upstream/master' into type-variables
Ericson2314 896dd74
Merge branch 'master' into type-variables
Ericson2314 640a445
Narrower `-XPatternSignatures` instead of `-Wpattern-signature-binds`
Ericson2314 868a8b7
Add SPJ's comment from #523
Ericson2314 7e8b858
Merge branch 'pattern-signatures-without-binds' into type-variables
Ericson2314 e1d3bee
Merge branch 'no-imply-type-abstractions' into pattern-signatures-wit…
Ericson2314 b824a66
Merge branch 'pattern-signatures-without-binds' into type-variables
Ericson2314 d3bcca8
Merge branch 'no-imply-type-abstractions' into pattern-signatures-wit…
Ericson2314 1ed93b9
Merge remote-tracking branch 'upstream/master' into pattern-signature…
Ericson2314 ad5a84a
Merge branch 'pattern-signatures-without-binds' into type-variables
Ericson2314 bd8a28e
Word-smithing
Ericson2314 a80cc45
Do not mention `-XImplicitBinds`
Ericson2314 c773b8a
Merge branch 'pattern-signatures-without-binds' (early part) into typ…
Ericson2314 f0ca5d9
Merge branch 'pattern-signatures-without-binds' into type-variables
Ericson2314 2f0a342
Revert "Do not mention `-XImplicitBinds`"
Ericson2314 f1426e3
Add examples
Ericson2314 0ce19ae
608: Fix type errors in quoted comment
Ericson2314 f2383fe
Merge branch 'pattern-signatures-without-binds' into type-variables
Ericson2314 017196f
Fix typos
Ericson2314 be556b8
Merge remote-tracking branch 'upstream/master' into pattern-signature…
Ericson2314 a7ff219
Merge branch 'pattern-signatures-without-binds' into type-variables
Ericson2314 1366216
Discuss interaction with #281 and implicit binding more clearly
Ericson2314 6590983
Merge branch 'pattern-signatures-without-binds' into type-variables
Ericson2314 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include a code example illustrating the difference between negative and positive position free vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit unsure about to what extent to include examples in the proposed change spec.