Skip to content

Commit

Permalink
mkDerivedConstants.c depends on ghcplatform.h
Browse files Browse the repository at this point in the history
I think this missing dep is what broke my parallel build
I used make -j2 with ghc-6.4.2.20060323 and got:

------------------------------------------------------------------------
==fptools== make boot -wr --jobserver-fds=3,11 -j;
in /var/tmp/portage/ghc-6.4.2_pre20060323/work/ghc-6.4.2.20060323/ghc/includes
------------------------------------------------------------------------
Creating ghcplatform.h...
Done.
gcc -O -O2 -march=k8 -pipe -Wa,--noexecstack    -c mkDerivedConstants.c -o mkDerivedConstants.o
In file included from ghcconfig.h:5,
                 from Stg.h:42,
                 from Rts.h:19,
                 from mkDerivedConstants.c:20:
ghcplatform.h:1:1: unterminated #ifndef
Done.
						    
With this patch applied I can no longer repoduce this build bug.
So I think this patch should be applied to the cvs ghc-6-4-branch too.
  • Loading branch information
Duncan Coutts committed Mar 24, 2006
1 parent 7997b73 commit 354cefe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ghc/includes/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ DerivedConstants.h :

else

mkDerivedConstants.c : $(H_CONFIG)
mkDerivedConstants.c : $(H_CONFIG) $(H_PLATFORM)

mkDerivedConstantsHdr : mkDerivedConstants.o
$(CC) -o $@ $(CC_OPTS) $(LD_OPTS) mkDerivedConstants.o
Expand Down

0 comments on commit 354cefe

Please sign in to comment.