Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add use case of -frelaxed #1223

Merged
merged 3 commits into from
Apr 14, 2020
Merged

doc: add use case of -frelaxed #1223

merged 3 commits into from
Apr 14, 2020

Conversation

radonnachie
Copy link
Contributor

Description

Related

Hosted

❤️ Thank you!

@eine eine added the Documentation: Restructured Text Related to documentation written in Restructured Text (ReST). label Apr 13, 2020
@umarcor
Copy link
Member

umarcor commented Apr 13, 2020

Currently, this PR conflicts with #1216, because doc/examples/README.rst is removed there. I decided to remove it because there are only VHPIDIRECT related examples/references ATM, and these are all moved to ghdl-cosim. If other examples are contributed in the future (PSL / formal verification, synthesis/PNR, https://ghdl.readthedocs.io/en/latest/development/Documentation.html...), the section can be added again. Nevertheless, I think that the content that you proposed to be added does fit in https://github.com/ghdl/ghdl-cosim/blob/master/doc/index.rst.

By the same token, the modification to Foreign.rst now corresponds to COSIM:VHPIDIRECT:Declarations in https://github.com/ghdl/ghdl-cosim/blob/master/doc/vhpidirect/declarations.rst.

I think that the addition in doc/examples/quick_start/README.rst is good.

@radonnachie
Copy link
Contributor Author

So I'll move the changes in doc/examples/README.rst and in Foreign.rst to a ghdl-cosim/.../doc... PR?

@umarcor
Copy link
Member

umarcor commented Apr 13, 2020

So I'll move the changes in doc/examples/README.rst and in Foreign.rst to a ghdl-cosim/.../doc... PR?

The change in Foreign.rst is not required (it'd be redundant with COSIM:VHPIDIRECT:Declarations). I would add the following (from your proposal) to https://github.com/ghdl/ghdl-cosim/blob/master/doc/index.rst as a hint:

It is suggested that users who are new to either GHDL or VHDL read, and execute, the examples in :ref:USING:QuickStart first.

The following sections contain advanced examples using specific features of the language, the tool,
or interaction with third-party projects.

@umarcor
Copy link
Member

umarcor commented Apr 13, 2020

I just found that I had moved the comment to: https://ghdl.github.io/ghdl-cosim/vhpidirect/examples/index.html (https://github.com/ghdl/ghdl-cosim/blob/master/doc/vhpidirect/examples/index.rst). It's up to you to reword/relocate it.

@radonnachie radonnachie changed the title Minor doc impr from umarcor/ghdl/pull/1 Add use case of -frelaxed (umarcor/ghdl/pull/1) Apr 14, 2020
@eine eine changed the title Add use case of -frelaxed (umarcor/ghdl/pull/1) doc: add use case of -frelaxed Apr 14, 2020
@eine eine merged commit add25cf into ghdl:master Apr 14, 2020
@eine eine added this to the v1.0 milestone May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: Restructured Text Related to documentation written in Restructured Text (ReST).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants