Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rooting datapack-dependent (GSI-502) #6

Merged
merged 2 commits into from
Nov 29, 2023
Merged

make rooting datapack-dependent (GSI-502) #6

merged 2 commits into from
Nov 29, 2023

Conversation

KerstenBreuer
Copy link
Contributor

@KerstenBreuer KerstenBreuer commented Nov 28, 2023 •
edited
Loading 

Rooting is no longer determined by the schemapack.
Instead the decision if something is rooted or not is
solely with the datapack. The same schemapack
can apply to rooted and unrooted datapacks.

@KerstenBreuer
make rooting datapack-dependent (GSI-502)
3c8c4aa 
Rooting is no longer determined by the schemapack. Instead the decision if something is rooted or not is solely with the datapack. The same schemapack applies to rooted and unrooted datapacks.
@KerstenBreuer
fix
9664ba2
@coveralls
Copy link

coveralls commented Nov 28, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 7025451987

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.7%) to 96.057%
Totals Coverage Status
Change from base Build 7024320012: 1.7%
Covered Lines: 609
Relevant Lines: 634
💛 - Coveralls

Cito
Cito approved these changes Nov 29, 2023
View reviewed changes
Copy link

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, makes things a bit simpler.

@KerstenBreuer KerstenBreuer merged commit 4be6c0d into main Nov 29, 2023
6 checks passed
@KerstenBreuer KerstenBreuer deleted the feature/datapack_root_GSI-502 branch November 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Cito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KerstenBreuer @coveralls @Cito