Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset tests #16

Merged
merged 29 commits into from
Oct 6, 2023
Merged

Add dataset tests #16

merged 29 commits into from
Oct 6, 2023

Conversation

sphamba
Copy link
Collaborator

@sphamba sphamba commented Oct 5, 2023

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Tutorial
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow :
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Improve a tutorial tutorial-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Summary

  • add script to generate small hdf5 files from downloaded raw files, and netcdf files from open_granule.
    • does not seem to work with all raw files (eg IMERG)
    • relies on start_date to be added in product_def.yml for all products
  • add tests for granule
    • test comparing small hdf5 files with saved netcdf file fails
  • add tests for groups and variables

evanjt and others added 29 commits August 18, 2023 03:24
…lter_by_time(), modify the default None behaviour to choose utcnow() instead of now() to avoid timezone related issues
@coveralls
Copy link

Coverage Status

coverage: 47.262% (+5.6%) from 41.632% when pulling 3514c12 on EPFL-ENAC:add_dataset_tests into 2fc2e2b on ghiggi:main.

Copy link
Owner

@ghiggi ghiggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sphamba sphamba marked this pull request as ready for review October 6, 2023 13:41
@sphamba sphamba merged commit 456b3c8 into ghiggi:main Oct 6, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants