Skip to content

Commit

Permalink
fix: sync row defatil grid option to fix build (#1138)
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiscoding committed Dec 30, 2023
1 parent a77c38e commit f51220f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 32 deletions.
2 changes: 0 additions & 2 deletions packages/aurelia-slickgrid/src/global-grid-options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,11 @@ export const GlobalGridOptions: Partial<GridOption> = {
syncGridSelectionWithBackendService: false, // but disable it when using backend services
},
datasetIdPropertyName: 'id',
defaultAureliaEventPrefix: '',
defaultFilter: Filters.input,
defaultBackendServiceFilterTypingDebounce: 500,
defaultColumnSortFieldId: 'id',
defaultFilterPlaceholder: '🔎︎', // magnifying glass icon
defaultFilterRangeOperator: OperatorType.rangeInclusive,
defaultSlickgridEventPrefix: '',
editable: false,
editorTypingDebounce: 450,
filterTypingDebounce: 0,
Expand Down
12 changes: 0 additions & 12 deletions packages/aurelia-slickgrid/src/models/gridOption.interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,6 @@ import { GridOption as UniversalGridOption } from '@slickgrid-universal/common';
import { RowDetailView } from './rowDetailView.interface';

export interface GridOption extends UniversalGridOption {
/**
* @deprecated this will be removed in future release and event prefixes will be removed completely.
* Default prefix for Aurelia Event names
*/
defaultAureliaEventPrefix?: string;

/**
* @deprecated this will be removed in future release and event prefixes will be removed completely.
* Default prefix for SlickGrid Event names
*/
defaultSlickgridEventPrefix?: string;

/** I18N translation service instance */
i18n?: I18N;

Expand Down
17 changes: 0 additions & 17 deletions packages/aurelia-slickgrid/src/models/rowDetailView.interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,4 @@ export interface RowDetailView extends UniversalRowDetailView {

/** View Model template that will be loaded once the async function finishes */
viewModel?: Constructable;

// --
// Callback Methods

/**
* HTML Preload Template that will be used before the async process (typically used to show a spinner/loading)
* It's preferable to use the "preloadView" property to use an Aurelia View instead of plain HTML.
* If you still wish to use these methods, we strongly suggest you to sanitize your HTML, e.g. "DOMPurify.sanitize()"
*/
preTemplate?: () => string;

/**
* HTML Post Template (when Row Detail data is available) that will be loaded once the async function finishes
* It's preferable to use the "preloadView" property to use an Aurelia View instead of plain HTML
* If you still wish to use these methods, we strongly suggest you to sanitize your HTML, e.g. "DOMPurify.sanitize()"
*/
postTemplate?: (item: any) => string;
}
2 changes: 1 addition & 1 deletion packages/demo/src/examples/slickgrid/example20.ts
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export class Example20 {

setFrozenColumns(frozenCols: number) {
this.gridObj.setOptions({ frozenColumn: frozenCols });
this.gridOptions = this.gridObj.getOptions() as GridOption;
this.gridOptions = this.gridObj.getOptions();
}

/** toggle dynamically, through slickgrid "setOptions()" the top/bottom pinned location */
Expand Down

0 comments on commit f51220f

Please sign in to comment.