feat(plugins): move all external SlickGrid controls/plugins & rewrite as internal extensions #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Nov 22, 2021
ghiscoding
commented
- remove all references to external 3rd party controls/plugins of SlickGrid core lib
- rewrite them all to vanilla JS (basically drop all jQuery code)
- with the rewrite and the move into internal code, we no longer need any extension bridges and so we no longer need internal code to use slickgrid event to communicate between extension & control/plugin, we now do this directly in the lib
- add full unit test coverage as well (prior to this PR, there wasn't any unit tests on external controls/plugins)
- use the code from the AutoTooltips SlickGrid Plugin code and implement it directly in the lib instead of having an extension that calls the plugin which is a bridge.
feat(addons): move controls/plugins from external into Slickgrid-Universal
…om/ghiscoding/slickgrid-universal into feat/internal-controls-and-plugins
- remove any reliance of the Grid Menu from SlickGrid fork, move everything internally into Slickgrid-Universal - the Grid Menu will no longer use SlickGrid Events, instead we will use the regular internal pubsub Service to do this - add new `alignDropSide` property to the Grid Menu options to choose which side to align the dropdown menu
- ColumnPicker/GridMenu share common code related to the column picker list, we can move this common code into a separate and shared file instead of keeping duplicate code (DRY)
Feat/internal grid menu
Feat/internal header button
feat(plugins): move external Header Menu into Slickgrid-Universal
feat(plugins): move external Cell Menu into Slickgrid-Universal
- there were some hidden characters that were carried over when doing copy+paste, and the only way I found to fix that was to replace `\u034f` (unicode char) with empty string - we should also trim the string to remove any empty spaces from start/end of string
…nsions refactor: move all controls/plugins to extensions folder
- makes it simpler to create & add options to a created DOM element, it also does proper inference
refactor: add new `createDomElement` utility
feat(utils): replace ext lib `assign-deep` by local `deepMerge` util
feat(core): add TS utility to infer extension instance by name
…a-style refactor: add style option to `createDomElement` util
refactor: add better inference on createDomElement & change export
…om/ghiscoding/slickgrid-universal into feat/internal-controls-and-plugins
…ault-import fix(build): add DOM purify optional default import to fix rollup builds
…om/ghiscoding/slickgrid-universal into feat/internal-controls-and-plugins
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 221 229 +8
Lines 14080 15754 +1674
Branches 4808 5287 +479
===========================================
+ Hits 14080 15754 +1674
Continue to review full report at Codecov.
|
ghiscoding-SE
pushed a commit
that referenced
this pull request
Nov 23, 2021
- after merging the big controls/plugins PR #555 that rewrote all the plugins, I just found out this simple option got missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.