Feat/internal header button #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in our current project, if we were to create a Grid View by hidding some columns and then revert to default Grid View and then creating a 2nd Grid View it would reuse the hidden columns from the 1st Grid View even though we wanted to base our 2nd Grid View from the base (which is supposed to have all columns shown)... so basically the issue was that we shouldn't keep/reuse of the columns, we should reevaluate every time
fix(state): don't use previous columns ref when getting current cols
feat(sanitize): make sure any string sent to innerHtml are sanitized
- fix an issue found that if we Edit a value (let say Title to "Task 1234") and then do a Mass Update on different field (say "% Complete" to 90%), the mass update was actually picking up the "Task 1234" from the previous edit even though it wasn't part of the Mass Update. So we can simply clear the `formValues` object when opening the modal window and before populating the form
…t-affecting-mass-update fix(composite): calling Edit change shouldn't affect Mass-Update
Codecov Report
@@ Coverage Diff @@
## feat/internal-controls-and-plugins #449 +/- ##
====================================================================
Coverage 100.00% 100.00%
====================================================================
Files 222 222
Lines 13736 13776 +40
Branches 4483 4496 +13
====================================================================
+ Hits 13736 13776 +40
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.